From 3ea6a2a17d020cff162c8a2e88041c2ecc3f4a0a Mon Sep 17 00:00:00 2001 From: Carlos Ruiz Date: Sat, 9 Feb 2019 14:26:45 +0100 Subject: [PATCH] IDEMPIERE-3887 Setup / Console-setup improvements --- .../compiere/install/ConfigurationData.java | 61 ++++++++++-------- .../compiere/install/ConfigurationPanel.java | 2 + .../src/org/compiere/install/KeyStoreMgt.java | 2 +- .../src/org/compiere/install/Setup_Help.java | 3 +- .../install/console/ConfigurationConsole.java | 2 +- .../org/compiere/install/images/Cancel16.gif | Bin 0 -> 878 bytes .../org/compiere/install/images/Cancel24.gif | Bin 0 -> 1268 bytes .../src/org/compiere/install/images/Ok16.gif | Bin 0 -> 626 bytes .../src/org/compiere/install/images/Ok24.gif | Bin 0 -> 936 bytes .../org/compiere/install/util/AppsAction.java | 9 ++- .../org/compiere/install/util/OnlineHelp.java | 2 +- .../db/oracle/config/ConfigOracle.java | 10 ++- .../postgresql/config/ConfigPostgreSQL.java | 10 ++- 13 files changed, 62 insertions(+), 39 deletions(-) create mode 100644 org.adempiere.install/src/org/compiere/install/images/Cancel16.gif create mode 100644 org.adempiere.install/src/org/compiere/install/images/Cancel24.gif create mode 100644 org.adempiere.install/src/org/compiere/install/images/Ok16.gif create mode 100644 org.adempiere.install/src/org/compiere/install/images/Ok24.gif diff --git a/org.adempiere.install/src/org/compiere/install/ConfigurationData.java b/org.adempiere.install/src/org/compiere/install/ConfigurationData.java index 4c26a33fc7..bd93530d99 100644 --- a/org.adempiere.install/src/org/compiere/install/ConfigurationData.java +++ b/org.adempiere.install/src/org/compiere/install/ConfigurationData.java @@ -296,6 +296,7 @@ public class ConfigurationData } InetAddress localhost = null; + @SuppressWarnings("unused") String hostName = "unknown"; try { @@ -318,7 +319,7 @@ public class ConfigurationData setKeyStore(KEYSTORE_PASSWORD); // AppsServer initAppsServer(); - setAppsServer(hostName); + setAppsServer("0.0.0.0"); // Database Server initDatabase(Database.DB_POSTGRESQL); String connectionName = getDatabaseDiscovered(); @@ -326,18 +327,16 @@ public class ConfigurationData setDatabaseName(resolveDatabaseName(connectionName)); } setDatabaseSystemPassword(""); - setDatabaseServer(hostName); + setDatabaseServer("localhost"); setDatabaseUser("adempiere"); setDatabasePassword("adempiere"); // Mail Server - if (p_panel != null) - { - p_panel.fMailServer.setText(hostName); - p_panel.fMailUser.setText("info"); - p_panel.fMailPassword.setText(""); - p_panel.fAdminEMail.setText("info@" + hostName); - } - // + setMailServer("localhost"); + //setMailUser("info"); + setMailUser(""); + setMailPassword(""); + //setAdminEMail("info@" + hostName); + setAdminEMail(""); } // !envLoaded // Default FTP stuff @@ -535,24 +534,28 @@ public class ConfigurationData ? p_panel.fAdminEMail.getText() : (String)p_properties.get(ADEMPIERE_ADMIN_EMAIL); InternetAddress adminEMail = null; - try - { - adminEMail = new InternetAddress (adminEMailString); - } - catch (Exception e) - { - error = "Not valid: " + adminEMailString + " - " + e.getMessage(); + if (adminEMailString != null && adminEMailString.length() > 0) { + try + { + adminEMail = new InternetAddress (adminEMailString); + } + catch (Exception e) + { + error = "Not valid: " + adminEMailString + " - " + e.getMessage(); + pass = false; + } + // + if (pass) + { + error = "Not verified EMail = " + adminEMail; + pass = testMailServer(mailServer, adminEMail, mailUser, mailPassword); + } + if (p_panel != null) + p_panel.signalOK(p_panel.okMailUser, "ErrorMail", + pass, false, error); + } else { pass = false; } - // - if (pass) - { - error = "Not verified EMail = " + adminEMail; - pass = testMailServer(mailServer, adminEMail, mailUser, mailPassword); - } - if (p_panel != null) - p_panel.signalOK(p_panel.okMailUser, "ErrorMail", - pass, false, error); if (pass) { if (log.isLoggable(Level.INFO)) log.info("OK: EMail = " + adminEMail); @@ -563,7 +566,11 @@ public class ConfigurationData } else { - log.warning(error); + if (adminEMailString != null && adminEMailString.length() > 0) { + log.warning(error); + } else { + if (log.isLoggable(Level.INFO)) log.info("OK: EMail not configured"); + } p_properties.setProperty(ADEMPIERE_ADMIN_EMAIL, ""); p_properties.setProperty(ADEMPIERE_MAIL_USER, ""); p_properties.setProperty(ADEMPIERE_MAIL_PASSWORD, ""); diff --git a/org.adempiere.install/src/org/compiere/install/ConfigurationPanel.java b/org.adempiere.install/src/org/compiere/install/ConfigurationPanel.java index 41bb66d8bc..ed04030599 100644 --- a/org.adempiere.install/src/org/compiere/install/ConfigurationPanel.java +++ b/org.adempiere.install/src/org/compiere/install/ConfigurationPanel.java @@ -602,6 +602,8 @@ public class ConfigurationPanel extends JPanel implements ActionListener, IDBCon } if (!pass && critical) cb.setBackground(Color.RED); + else if (!pass && !critical) + cb.setBackground(Color.YELLOW); else cb.setBackground(Color.GREEN); } // setOK diff --git a/org.adempiere.install/src/org/compiere/install/KeyStoreMgt.java b/org.adempiere.install/src/org/compiere/install/KeyStoreMgt.java index 024bc3da14..bcb480413c 100644 --- a/org.adempiere.install/src/org/compiere/install/KeyStoreMgt.java +++ b/org.adempiere.install/src/org/compiere/install/KeyStoreMgt.java @@ -300,7 +300,7 @@ public class KeyStoreMgt : System.getProperty("user.name"); String o = mgt.organizationUnit != null ? mgt.organizationUnit - : "AdempiereUser"; + : "iDempiereUser"; String l = mgt.location != null ? mgt.location : "MyTown"; diff --git a/org.adempiere.install/src/org/compiere/install/Setup_Help.java b/org.adempiere.install/src/org/compiere/install/Setup_Help.java index 735dd1f779..5fa158c77e 100644 --- a/org.adempiere.install/src/org/compiere/install/Setup_Help.java +++ b/org.adempiere.install/src/org/compiere/install/Setup_Help.java @@ -99,6 +99,7 @@ public class Setup_Help extends JDialog implements ActionListener } catch (Exception ex) { + ex.printStackTrace(); } } // init @@ -139,7 +140,7 @@ public class Setup_Help extends JDialog implements ActionListener { try { - editorPane.setPage("http://www.adempiere.com/wiki/index.php/ServerSetupHelp"); + editorPane.setPage("http://wiki.idempiere.org/en/Server_Setup_Help"); } catch (IOException ex) { diff --git a/org.adempiere.install/src/org/compiere/install/console/ConfigurationConsole.java b/org.adempiere.install/src/org/compiere/install/console/ConfigurationConsole.java index 643b12273e..ed2928aa95 100644 --- a/org.adempiere.install/src/org/compiere/install/console/ConfigurationConsole.java +++ b/org.adempiere.install/src/org/compiere/install/console/ConfigurationConsole.java @@ -322,7 +322,7 @@ public class ConfigurationConsole { cn = System.getProperty("user.name"); String ou = data.getProperty(ConfigurationData.ADEMPIERE_CERT_ORG_UNIT); if (ou == null) - ou = "AdempiereUser"; + ou = "iDempiereUser"; String o = data.getProperty(ConfigurationData.ADEMPIERE_CERT_ORG); if (o == null) o = System.getProperty("user.name"); diff --git a/org.adempiere.install/src/org/compiere/install/images/Cancel16.gif b/org.adempiere.install/src/org/compiere/install/images/Cancel16.gif new file mode 100644 index 0000000000000000000000000000000000000000..9beb8fcec140f157c945ea0c69220c7880f02741 GIT binary patch literal 878 zcmV-!1CjiRP)#ZWtGIbU=uGYE5CMTf6Tld+HEXp`jU6~=KFnlc`qMS6;&k*r+oM= z3-30x-JONE$Nuu1ZD zVbFA(uim+O)onR=kgX?A_;GZ!9M@_ed8%`Nhx^1ZCewq1$u|xhV5?MOX?i-W2f;=0 zVJYQ#sW&qjD$C0>9XiDJ^XL3<>sC3gRxbguVObL=hlkyyZ4=~jB+_Y~E-v!N!-va~ zg^Xp}^W7sON!PZCR#!>1wz9Ln&cf~6fvD1b`Lg3$7GXY5;>Z!!U%VhcI~%C#fT$|I zNU!NQQ@tZ2uA4{@6^kTVTM4$eK@~fSs1^zsZEb9BZ17-wJXF<-p6ZMN;HfS|K`^v% z^JY+~)kw6r6R)k2v~64w;$o4ewl;z=MyS^nvk)Vq1><~SAglueJsA2+Q7%|ZDuRvo1 zU*v+-)bwTFwQIIhE>oSFqB)g9RH+pTNJj^OY4ZK#WKgfyuXw6o{4>B888A%q>&%%m z&Yn0XT3NwPrwL3G5y6Qfs!L0l$B(mBuk+LFY#7J!u&4U1WT96KV=CR>@3x3gFBEW2 zoM01JoS6v)Cas`|bmFxGbTsGHoommr@fkxEgjR{7=b z-5`#l52GmhN;v)flqwZ|ou3ah zjz92J?|G^daTI;LI5!u*s?})f>0$HbOP&^sVGK7KlnsqpRxp3;nEE0+S?K!@5>NYv zQC{fk(lN^lvT#9FdEGGN!|z$>`5&B5jlpUbE;Y120h+YAyCRB#FaQ7m07*qoM6N<$ Ef^$rr6951J literal 0 HcmV?d00001 diff --git a/org.adempiere.install/src/org/compiere/install/images/Cancel24.gif b/org.adempiere.install/src/org/compiere/install/images/Cancel24.gif new file mode 100644 index 0000000000000000000000000000000000000000..d91a52dc0c631b17dc1132962d0b4495ab7c4221 GIT binary patch literal 1268 zcmVb z(_KtcXBY?Y|8q`(bEJGzTCnXYW*5jzP+<}SUTJU_+_21y7Nf2Z0`V(uce|#6_)?uS$t6R-mWSp7ZQtEg~@E&7S0+yf@D;@B2RQ zOU#V_qlDDrGLh&Zy6}r6g}p?_J{0f}9rp;rjF;%*Wg_t%xSz-n2d+5CB=R@4*gBA#2T~(DVh~j69Fwf4OdF=JRF_=s+_<7j8?0=s-Z#Fo<2o?gS)b+Ny69|^dv4?EP$p#^ZSvQoCI=mpcfb8;k9eA*%vP^x|k0y zbymPBJg>aG`IFtdGiY=a91cUs%>~8dNK8xs>FLnSX58=Yj?GU^U2-xXT5hZgr-qbY zR@Sn0&z=nS`@z8=I1m6!5(I|>zjb%V)R!+i8krBS)^Au<1t0*Nn4f1P65#oH=ue(N z1i-Qk5P_JPmi*jR`d5~h=(N#pZ`skS zLv(I6W5rc?h)x+zrq(T=e=hOk$IzcWLz=?@gQ9>00h-T;_~az0xEQ+Kj)6OO)acC2 zPfq5x|Af6nCo_wR+BVkKN<2Ia%*-IYv=n5w{No8bTr%glM$_{~k3OjYNKEWIoWy zd{B)3lA!*~|SV*CYg2CS2 zX!P~#ADztmQ%7_%ABxV-UV7Nmqv|CkFgP4|@dLLk5=C{N9mMDE4&>;#!Lrm8@ znt|g0(g29b2mlBG1JD6z0JMw1fi*{4jS-Z5L(c|=3j8IP(;yaC`GjG zs>;F%+2ka{cyXA8v zrN-a(`^STo<@W8L;RjFSC2eZ58W9pQ_W+;!2&oIxY<^@*k0g@TlAANLxrM}e<MVq0?y_y^edGEi6uM&dla+X0;rR$_iy;m^+d5 zw#sYC($sY3<%E)vDG@*j;KPA!n@0PfTimD|SpuPCj4=v96af%i(54wcZmqruRW*~k zswOol2q?JcW8m3nw@ssEb&DGn*8%`m(D@tAk99T{^pt>XG) z$2zNzQziZ=A&lgkb^B9o*D9|420k<8p``B&axJSf|GeC@|LJpm1Ax5dNw1t*Bme*a M07*qoM6N<$f+b-iI{*Lx literal 0 HcmV?d00001 diff --git a/org.adempiere.install/src/org/compiere/install/images/Ok24.gif b/org.adempiere.install/src/org/compiere/install/images/Ok24.gif new file mode 100644 index 0000000000000000000000000000000000000000..027d18f53194005ce4fd7feb1cacdd34079a2f86 GIT binary patch literal 936 zcmV;Z16TZsP)rlw3&J^L?ECq}sjrCW$9hBY3;Tn5Lvb!x^KyB%hAhV| z8)n;2+CN!iKiJ#|Gy1Q%5WKm#GFwAdYlLzO* z9noC6I#=U%g4;|0L@*fxAlSsTEC=1e8b5M?DJAbNU77ph+B^E%+B&~`|6Y0~?l_`Z zzB*rX#UzK3AQ0^SofFFdicQcBAMgV_pU-`_vRb-%X=YyL3Zl~A3*TN_XD1@{hT>8> z&E?9QHBY|5$-2NkO#~2+VOUT9)q3t5V?O2ehGO|b?%S2s(#?hWMKM;Ggd=lIdZ_eX ziqsp5yY2`tcr%>A1&BcVpKd9Fwt;@ydhTbLxwW|w8vg!=V|T8sUjC@Guq2B4aR3%l zxRBCiQlZl8jw00?4$tLebNQ`OZM-nc1+me)~`>$F|gAsmC}ugu{q93BFoI-7$sR3QM#+Qw>rK)f&&1* z{x0tHgRsh7Q_iablhQpL4oA3fq-3t5%GAu*^7PaKlaBXdfCz|_U4(I0Z$Iw%X{wLm z0Ko6xOYQY4eccbjs&I8#DUV6%9g9dQSusCJ((wQ~m`;mfyn{iwr~iE1@ss2v4geeg zUPOjfA+xfl9OgO-L?cQH7n}=#EXWd!jW8H?&>QshACEeI9H*z^hk@gfsOm^tc0J96 zumB8-V-F4gVcK5jZWPRE{~0000c51Uox{ZvFPmABOQO@lyk*M)EF8k`(QBS3i09%n#3r zpBXqU67(ap_3&?hFo@2LpX)uSHxw@vy&uw42XT~sa`d%&J=Q-U(WIS3N#DKz0000< KMNUMnLSTaOowC6I literal 0 HcmV?d00001 diff --git a/org.adempiere.install/src/org/compiere/install/util/AppsAction.java b/org.adempiere.install/src/org/compiere/install/util/AppsAction.java index d7c712dc55..294367cdbf 100644 --- a/org.adempiere.install/src/org/compiere/install/util/AppsAction.java +++ b/org.adempiere.install/src/org/compiere/install/util/AppsAction.java @@ -20,6 +20,7 @@ import java.awt.Dimension; import java.awt.Insets; import java.awt.event.ActionEvent; import java.awt.event.ActionListener; +import java.net.URL; import javax.swing.AbstractAction; import javax.swing.AbstractButton; @@ -33,6 +34,7 @@ import javax.swing.JMenuItem; import javax.swing.JToggleButton; import javax.swing.KeyStroke; +import org.compiere.install.ConfigurationPanel; import org.compiere.util.Env; import org.compiere.util.Msg; @@ -178,8 +180,11 @@ public final class AppsAction extends AbstractAction */ private ImageIcon getIcon(String name, boolean small) { - String fullName = name + (small ? "16" : "24"); - return Env.getImageIcon2(fullName); + String fullName = name + (small ? "16" : "24") + ".gif"; + URL imageURL = ConfigurationPanel.class.getResource("images/"+fullName); + if (imageURL == null) + return null; + return new ImageIcon(imageURL); } // getIcon /** diff --git a/org.adempiere.install/src/org/compiere/install/util/OnlineHelp.java b/org.adempiere.install/src/org/compiere/install/util/OnlineHelp.java index 5761627216..a58465507a 100644 --- a/org.adempiere.install/src/org/compiere/install/util/OnlineHelp.java +++ b/org.adempiere.install/src/org/compiere/install/util/OnlineHelp.java @@ -94,7 +94,7 @@ public class OnlineHelp extends JEditorPane implements HyperlinkListener } // OnlineHelp /** Base of Online Help System */ - protected static final String BASE_URL = "http://www.adempiere.com/wiki/index.php/OnlineLoginHelp"; + protected static final String BASE_URL = "http://wiki.idempiere.org/en/Server_Setup_Help"; public static void openInDefaultBrowser() { diff --git a/org.compiere.db.oracle.provider/src/org/adempiere/db/oracle/config/ConfigOracle.java b/org.compiere.db.oracle.provider/src/org/adempiere/db/oracle/config/ConfigOracle.java index 2e4ad68249..7aa242a26c 100644 --- a/org.compiere.db.oracle.provider/src/org/adempiere/db/oracle/config/ConfigOracle.java +++ b/org.compiere.db.oracle.provider/src/org/adempiere/db/oracle/config/ConfigOracle.java @@ -392,9 +392,13 @@ public class ConfigOracle implements IDatabaseConfig // Ignore result as it might not be imported pass = testJDBC(url, databaseUser, databasePassword); error = "Cannot connect to User: " + databaseUser + "/" + databasePassword + " - Database may not be imported yet (OK on initial run)."; - if (monitor != null) - monitor.update(new DBConfigStatus(DBConfigStatus.DATABASE_USER, "ErrorJDBC", - pass, true, error)); + if (monitor != null) { + boolean critical = true; + if (!isDBExists) { + critical = false; + } + monitor.update(new DBConfigStatus(DBConfigStatus.DATABASE_USER, "ErrorJDBC", pass, critical, error)); + } if (pass) { if (log.isLoggable(Level.INFO)) log.info("OK: Database User = " + databaseUser); diff --git a/org.compiere.db.postgresql.provider/src/org/adempiere/db/postgresql/config/ConfigPostgreSQL.java b/org.compiere.db.postgresql.provider/src/org/adempiere/db/postgresql/config/ConfigPostgreSQL.java index f7019eab34..6454a9d52c 100755 --- a/org.compiere.db.postgresql.provider/src/org/adempiere/db/postgresql/config/ConfigPostgreSQL.java +++ b/org.compiere.db.postgresql.provider/src/org/adempiere/db/postgresql/config/ConfigPostgreSQL.java @@ -158,9 +158,13 @@ public class ConfigPostgreSQL implements IDatabaseConfig // Ignore result as it might not be imported pass = testJDBC(url, databaseUser, databasePassword); error = "Database imported? Cannot connect to User: " + databaseUser + "/" + databasePassword; - if (monitor != null) - monitor.update(new DBConfigStatus(DBConfigStatus.DATABASE_USER, "ErrorJDBC", - pass, true, error)); + if (monitor != null) { + boolean critical = true; + if (!isDBExists) { + critical = false; + } + monitor.update(new DBConfigStatus(DBConfigStatus.DATABASE_USER, "ErrorJDBC", pass, critical, error)); + } if (pass) { if (log.isLoggable(Level.INFO)) log.info("OK: Database User = " + databaseUser);