midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IDEMPIERE-455 Discover and fix FindBugs problems / RV_RETURN_VALUE_IGNORED 

http://findbugs.sourceforge.net/bugDescriptions.html#RV_RETURN_VALUE_IGNORED
This commit is contained in:
Richard Morales 2012-10-16 15:41:49 -05:00
parent 650f1344fd
commit 3d25237fb6
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
org.adempiere.base/src/org/compiere/db/CreateAdempiere.java
View File

@ -417,7 +417,7 @@ public class CreateAdempiere
if (def != null) if (def != null)
{ {
//jz: replace '' to \', otherwise exception //jz: replace '' to \', otherwise exception
def.replaceAll("''", "\\'"); def = def.replaceAll("''", "\\'");
sb.append(" DEFAULT ").append(def); sb.append(" DEFAULT ").append(def);
} }
// Null // Null

4
org.adempiere.base/src/org/compiere/model/GridTabVO.java
View File

@ -214,8 +214,8 @@ public class GridTabVO implements Evaluatee, Serializable
if (vo.WhereClause == null) if (vo.WhereClause == null)
vo.WhereClause = ""; vo.WhereClause = "";
//jz col=null not good for Derby //jz col=null not good for Derby
if (vo.WhereClause.indexOf("=null")>0) if (vo.WhereClause.indexOf("=null")>0)
vo.WhereClause.replaceAll("=null", " IS NULL "); vo.WhereClause = vo.WhereClause.replaceAll("=null", " IS NULL ");
// Where Clauses should be surrounded by parenthesis - teo_sarca, BF [ 1982327 ] // Where Clauses should be surrounded by parenthesis - teo_sarca, BF [ 1982327 ]
if (vo.WhereClause.trim().length() > 0) { if (vo.WhereClause.trim().length() > 0) {
vo.WhereClause = "("+vo.WhereClause+")"; vo.WhereClause = "("+vo.WhereClause+")";

2
org.adempiere.base/src/org/globalqss/process/CashFlow.java
View File

@ -225,7 +225,7 @@ public class CashFlow extends SvrProcess {
open = open.subtract(paid); open = open.subtract(paid);
} }
if (open.scale() > curr.getStdPrecision()) if (open.scale() > curr.getStdPrecision())
open.setScale(curr.getStdPrecision(), BigDecimal.ROUND_HALF_UP); open = open.setScale(curr.getStdPrecision(), BigDecimal.ROUND_HALF_UP);
BigDecimal invoiced = order.getGrandTotal().subtract(open); BigDecimal invoiced = order.getGrandTotal().subtract(open);
if (isPaySchedule) { if (isPaySchedule) {
MOrderPaySchedule[] schedule = MOrderPaySchedule.getOrderPaySchedule(getCtx(), order_id, 0, get_TrxName()); MOrderPaySchedule[] schedule = MOrderPaySchedule.getOrderPaySchedule(getCtx(), order_id, 0, get_TrxName());