midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IDEMPIERE-1732 two users can complete same M_InOut and data is corrupted / integrate patch from hengsin

This commit is contained in:
Carlos Ruiz 2014-02-05 09:59:18 -05:00
parent fef5e02b27
commit 3c8bc873dc
1 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
org.adempiere.base/src/org/compiere/process/DocumentEngine.java
View File

@ -229,6 +229,21 @@ public class DocumentEngine implements DocAction
*/
public boolean processIt (String processAction, String docAction)
{
//ensure doc status not change by other session
if (m_document instanceof PO) {
PO docPO = (PO) m_document;
if (docPO.get_ID() > 0 && docPO.get_TrxName() != null && docPO.get_ValueOld("DocStatus") != null) {
DB.getDatabase().forUpdate(docPO, 30);
String docStatusOriginal = (String) docPO.get_ValueOld("DocStatus");
String currentStatus = DB.getSQLValueString((String)null,
"SELECT DocStatus FROM " + docPO.get_TableName() + " WHERE " + docPO.get_KeyColumns()[0] + " = ? ",
docPO.get_ID());
if (!docStatusOriginal.equals(currentStatus) && currentStatus != null) {
throw new IllegalStateException("Document status have been change by other session, please refresh your window and try again. " + docPO.toString());
}
}
}
m_message = null;
m_action = null;
// Std User Workflows - see MWFNodeNext.isValidFor
@ -1270,21 +1285,6 @@ public class DocumentEngine implements DocAction
public static boolean processIt(DocAction doc, String processAction) {
boolean success = false;
//ensure doc status not change by other session
if (doc instanceof PO) {
PO docPO = (PO) doc;
if (docPO.get_ID() > 0 && docPO.get_TrxName() != null && docPO.get_ValueOld("DocStatus") != null) {
DB.getDatabase().forUpdate(docPO, 30);
String docStatusOriginal = (String) docPO.get_ValueOld("DocStatus");
String currentStatus = DB.getSQLValueString((String)null,
"SELECT DocStatus FROM " + docPO.get_TableName() + " WHERE " + docPO.get_KeyColumns()[0] + " = ? ",
docPO.get_ID());
if (!docStatusOriginal.equals(currentStatus) && currentStatus != null) {
throw new IllegalStateException("Document status have been change by other session, please refresh your window and try again. " + docPO.toString());
}
}
}
DocumentEngine engine = new DocumentEngine(doc, doc.getDocStatus());
success = engine.processIt(processAction, doc.getDocAction());