midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

FR: [ 2214883 ] Remove SQL code and Replace for Query (thanks Trifon for the last review and correction. 

-- JUnit test included (no failures)
This commit is contained in:
Redhuan D. Oon 2010-02-25 21:08:04 +00:00
parent 025e667dd2
commit 398eaf6f10
2 changed files with 48 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
base/src/org/compiere/model/MProductBOM.java
View File

@ -19,6 +19,7 @@ package org.compiere.model;
import java.sql.PreparedStatement; import java.sql.PreparedStatement;
import java.sql.ResultSet; import java.sql.ResultSet;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List;
import java.util.Properties; import java.util.Properties;
import java.util.logging.Level; import java.util.logging.Level;
@ -62,35 +63,13 @@ public class MProductBOM extends X_M_Product_BOM
*/ */
public static MProductBOM[] getBOMLines (Properties ctx, int M_Product_ID, String trxName) public static MProductBOM[] getBOMLines (Properties ctx, int M_Product_ID, String trxName)
{ {
String sql = "SELECT * FROM M_Product_BOM WHERE M_Product_ID=? ORDER BY Line"; //FR: [ 2214883 ] Remove SQL code and Replace for Query - red1
ArrayList<MProductBOM> list = new ArrayList<MProductBOM>(); String whereClause = "M_Product_ID=?";
PreparedStatement pstmt = null; List <MProductBOM> list = new Query(ctx, MProductBOM.Table_Name, whereClause, trxName)
try .setParameters(new Object[]{M_Product_ID})
{ .setOrderBy("Line")
pstmt = DB.prepareStatement(sql, trxName); .list();
pstmt.setInt(1, M_Product_ID);
ResultSet rs = pstmt.executeQuery();
while (rs.next())
list.add(new MProductBOM (ctx, rs, trxName));
rs.close();
pstmt.close();
pstmt = null;
}
catch (Exception e)
{
s_log.log(Level.SEVERE, sql, e);
}
try
{
if (pstmt != null)
pstmt.close();
pstmt = null;
}
catch (Exception e)
{
pstmt = null;
}
//
// s_log.fine("getBOMLines - #" + list.size() + " - M_Product_ID=" + M_Product_ID); // s_log.fine("getBOMLines - #" + list.size() + " - M_Product_ID=" + M_Product_ID);
MProductBOM[] retValue = new MProductBOM[list.size()]; MProductBOM[] retValue = new MProductBOM[list.size()];
list.toArray(retValue); list.toArray(retValue);

40
extend/src/test/functional/MProductBOMTest.java Normal file
View File

@ -0,0 +1,40 @@
/******************************************************************************
* Product: Adempiere ERP & CRM Smart Business Solution *
* Copyright (C) 2008 SC ARHIPAC SERVICE SRL. All Rights Reserved. *
* This program is free software; you can redistribute it and/or modify it *
* under the terms version 2 of the GNU General Public License as published *
* by the Free Software Foundation. This program is distributed in the hope *
* that it will be useful, but WITHOUT ANY WARRANTY; without even the implied *
* warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. *
* See the GNU General Public License for more details. *
* You should have received a copy of the GNU General Public License along *
* with this program; if not, write to the Free Software Foundation, Inc., *
* 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA. *
*****************************************************************************/
package test.functional;
import org.compiere.model.MProductBOM;
import org.compiere.util.Env;
import test.AdempiereTestCase;
/**
* @author Teo Sarca, www.arhipac.ro // used by red1
*/
public class MProductBOMTest extends AdempiereTestCase
{
@Override
protected void setUp() throws Exception
{
super.setUp();
assertEquals("Client is not GardenWorld", 11, Env.getAD_Client_ID(getCtx()));
}
public void testQuery() throws Exception
{
MProductBOM[] lines = MProductBOM.getBOMLines(getCtx(), 145, getTrxName());
assertTrue("ProductBOM should have lines", lines.length > 0);
}
}