midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BF [ 1739544 ] getLookup_TableEmbed error for self referecing references 

http://sourceforge.net/tracker/index.php?func=detail&aid=1739544&group_id=176962&atid=879332
This commit is contained in:
teo_sarca 2007-06-19 11:43:27 +00:00
parent 52d9e4dc1a
commit 2e501c565d
1 changed files with 17 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
base/src/org/compiere/model/MLookupFactory.java
View File

@ -27,7 +27,7 @@ import org.compiere.util.*;
* @author Jorg Janke * @author Jorg Janke
* @version $Id: MLookupFactory.java,v 1.3 2006/07/30 00:58:04 jjanke Exp $ * @version $Id: MLookupFactory.java,v 1.3 2006/07/30 00:58:04 jjanke Exp $
* *
* @author Teo Sarca - BF [ 1734394 ], BF [ 1714261 ], BF [ 1672820 ], BF [ 1739530 ] * @author Teo Sarca - BF [ 1734394 ], BF [ 1714261 ], BF [ 1672820 ], BF [ 1739530 ], BF [ 1739544 ]
*/ */
public class MLookupFactory public class MLookupFactory
{ {
@ -473,7 +473,7 @@ public class MLookupFactory
+ "WHERE rt.AD_Reference_ID=?" + "WHERE rt.AD_Reference_ID=?"
+ " AND rt.IsActive='Y' AND t.IsActive='Y'"; + " AND rt.IsActive='Y' AND t.IsActive='Y'";
// //
String KeyColumn, DisplayColumn, TableName; String KeyColumn, DisplayColumn, TableName, TableNameAlias;
boolean IsTranslated, isValueDisplayed; boolean IsTranslated, isValueDisplayed;
try try
@ -504,6 +504,14 @@ public class MLookupFactory
s_log.log(Level.SEVERE, sql, e); s_log.log(Level.SEVERE, sql, e);
return null; return null;
} }
// If it's self referencing then use other alias - teo_sarca [ 1739544 ]
if (TableName.equals(BaseTable)) {
TableNameAlias = TableName + "1";
}
else {
TableNameAlias = TableName;
}
StringBuffer embedSQL = new StringBuffer("SELECT "); StringBuffer embedSQL = new StringBuffer("SELECT ");
@ -511,12 +519,12 @@ public class MLookupFactory
if (IsTranslated && !Env.isBaseLanguage(language, TableName)) if (IsTranslated && !Env.isBaseLanguage(language, TableName))
{ {
if (isValueDisplayed) if (isValueDisplayed)
embedSQL.append(TableName).append(".Value||'-'||"); embedSQL.append(TableNameAlias).append(".Value||'-'||");
embedSQL.append(TableName).append("_Trl.").append(DisplayColumn); embedSQL.append(TableName).append("_Trl.").append(DisplayColumn);
// //
embedSQL.append(" FROM ").append(TableName) embedSQL.append(" FROM ").append(TableName).append(" ").append(TableNameAlias)
.append(" INNER JOIN ").append(TableName).append("_TRL ON (") .append(" INNER JOIN ").append(TableName).append("_TRL ON (")
.append(TableName).append(".").append(KeyColumn) .append(TableNameAlias).append(".").append(KeyColumn)
.append("=").append(TableName).append("_Trl.").append(KeyColumn) .append("=").append(TableName).append("_Trl.").append(KeyColumn)
.append(" AND ").append(TableName).append("_Trl.AD_Language='") .append(" AND ").append(TableName).append("_Trl.AD_Language='")
.append(language.getAD_Language()).append("')"); .append(language.getAD_Language()).append("')");
@ -525,14 +533,14 @@ public class MLookupFactory
else else
{ {
if (isValueDisplayed) if (isValueDisplayed)
embedSQL.append(TableName).append(".Value||'-'||"); embedSQL.append(TableNameAlias).append(".Value||'-'||");
embedSQL.append(TableName).append(".").append(DisplayColumn); embedSQL.append(TableNameAlias).append(".").append(DisplayColumn);
// //
embedSQL.append(" FROM ").append(TableName); embedSQL.append(" FROM ").append(TableName).append(" ").append(TableNameAlias);
} }
embedSQL.append(" WHERE ").append(BaseTable).append(".").append(BaseColumn); embedSQL.append(" WHERE ").append(BaseTable).append(".").append(BaseColumn);
embedSQL.append("=").append(TableName).append(".").append(KeyColumn); embedSQL.append("=").append(TableNameAlias).append(".").append(KeyColumn);
return embedSQL.toString(); return embedSQL.toString();
} // getLookup_TableEmbed } // getLookup_TableEmbed