midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BF [ 1807368 ] DataEngine does not close DB connection 

http://sourceforge.net/tracker/index.php?func=detail&aid=1807368&group_id=176962&atid=879332
This commit is contained in:
teo_sarca 2007-10-04 18:29:07 +00:00
parent 797ad0389e
commit 24bb00b332
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
base/src/org/compiere/print/DataEngine.java
View File

@ -29,7 +29,9 @@ import org.compiere.util.*;
* @author Jorg Janke * @author Jorg Janke
* @version $Id: DataEngine.java,v 1.3 2006/07/30 00:53:02 jjanke Exp $ * @version $Id: DataEngine.java,v 1.3 2006/07/30 00:53:02 jjanke Exp $
* *
* @author Teo Sarca, SC ARHIPAC SERVICE SRL - BF [ 1761891 ] * @author Teo Sarca, SC ARHIPAC SERVICE SRL
* <li>BF [ 1761891 ] Included print format with report view attached issue
* <li>BF [ 1807368 ] DataEngine does not close DB connection
*/ */
public class DataEngine public class DataEngine
{ {
@ -198,11 +200,13 @@ public class DataEngine
+ "WHERE pf.AD_PrintFormat_ID=?" // #1 + "WHERE pf.AD_PrintFormat_ID=?" // #1
+ " AND pfi.IsActive='Y' AND (pfi.IsPrinted='Y' OR c.IsKey='Y' OR pfi.SortNo > 0) " + " AND pfi.IsActive='Y' AND (pfi.IsPrinted='Y' OR c.IsKey='Y' OR pfi.SortNo > 0) "
+ "ORDER BY pfi.IsPrinted DESC, pfi.SeqNo"; // Functions are put in first column + "ORDER BY pfi.IsPrinted DESC, pfi.SeqNo"; // Functions are put in first column
PreparedStatement pstmt = null;
ResultSet rs = null;
try try
{ {
PreparedStatement pstmt = DB.prepareStatement(sql, null); pstmt = DB.prepareStatement(sql, null);
pstmt.setInt(1, format.get_ID()); pstmt.setInt(1, format.get_ID());
ResultSet rs = pstmt.executeQuery(); rs = pstmt.executeQuery();
m_synonym = "A"; // synonym m_synonym = "A"; // synonym
while (rs.next()) while (rs.next())
@ -519,6 +523,12 @@ public class DataEngine
{ {
log.log(Level.SEVERE, "SQL=" + sql + " - ID=" + format.get_ID(), e); log.log(Level.SEVERE, "SQL=" + sql + " - ID=" + format.get_ID(), e);
} }
finally {
DB.close(rs);
DB.close(pstmt);
rs = null;
pstmt = null;
}
if (columns.size() == 0) if (columns.size() == 0)
{ {