midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BF [ 1896885 ] BS Line: don't update header if after save/delete fails

This commit is contained in:
teo_sarca 2008-08-08 06:49:30 +00:00
parent ab37a3eeac
commit 22df2fec30
1 changed files with 21 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
base/src/org/compiere/model/MBankStatementLine.java
View File

@ -30,6 +30,9 @@ import org.compiere.util.*;
* *
* Carlos Ruiz - globalqss - integrate bug fixing from Teo Sarca * Carlos Ruiz - globalqss - integrate bug fixing from Teo Sarca
* [ 1619076 ] Bank statement's StatementDifference becames NULL * [ 1619076 ] Bank statement's StatementDifference becames NULL
*
* @author Teo Sarca, SC ARHIPAC SERVICE SRL
* <li>BF [ 1896885 ] BS Line: don't update header if after save/delete fails
*/ */
public class MBankStatementLine extends X_C_BankStatementLine public class MBankStatementLine extends X_C_BankStatementLine
{ {
@ -188,8 +191,9 @@ import org.compiere.util.*;
*/ */
protected boolean afterSave (boolean newRecord, boolean success) protected boolean afterSave (boolean newRecord, boolean success)
{ {
updateHeader(); if (!success)
return success; return success;
return updateHeader();
} // afterSave } // afterSave
/** /**
@ -199,24 +203,34 @@ import org.compiere.util.*;
*/ */
protected boolean afterDelete (boolean success) protected boolean afterDelete (boolean success)
{ {
updateHeader(); if (!success)
return success; return success;
return updateHeader();
} // afterSave } // afterSave
/** /**
* Update Header * Update Header
*/ */
private void updateHeader() private boolean updateHeader()
{ {
String sql = "UPDATE C_BankStatement bs" String sql = "UPDATE C_BankStatement bs"
+ " SET StatementDifference=(SELECT COALESCE(SUM(StmtAmt),0) FROM C_BankStatementLine bsl " + " SET StatementDifference=(SELECT COALESCE(SUM(StmtAmt),0) FROM C_BankStatementLine bsl "
+ "WHERE bsl.C_BankStatement_ID=bs.C_BankStatement_ID AND bsl.IsActive='Y') " + "WHERE bsl.C_BankStatement_ID=bs.C_BankStatement_ID AND bsl.IsActive='Y') "
+ "WHERE C_BankStatement_ID=" + getC_BankStatement_ID(); + "WHERE C_BankStatement_ID=" + getC_BankStatement_ID();
DB.executeUpdate(sql, get_TrxName()); int no = DB.executeUpdate(sql, get_TrxName());
if (no != 1) {
log.warning("StatementDifference #" + no);
return false;
}
sql = "UPDATE C_BankStatement bs" sql = "UPDATE C_BankStatement bs"
+ " SET EndingBalance=BeginningBalance+StatementDifference " + " SET EndingBalance=BeginningBalance+StatementDifference "
+ "WHERE C_BankStatement_ID=" + getC_BankStatement_ID(); + "WHERE C_BankStatement_ID=" + getC_BankStatement_ID();
DB.executeUpdate(sql, get_TrxName()); no = DB.executeUpdate(sql, get_TrxName());
if (no != 1) {
log.warning("Balance #" + no);
return false;
}
return true;
} // updateHeader } // updateHeader
} // MBankStatementLine } // MBankStatementLine