midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IDEMPIERE-5305 : ORA-01704: string literal too long when trying to update a mail template (#1353)

This commit is contained in:
Nicolas Micoud 2022-06-02 08:27:00 +02:00 committed by GitHub
parent cbaff160df
commit 20116c6144
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
org.adempiere.base/src/org/compiere/model/PO.java
View File

@ -4049,6 +4049,7 @@ public abstract class PO
.append(tableName).append("_Trl SET "); .append(tableName).append("_Trl SET ");
// //
ArrayList<Object> values = new ArrayList<Object>();
StringBuilder sqlcols = new StringBuilder(); StringBuilder sqlcols = new StringBuilder();
for (int i = 0; i < p_info.getColumnCount(); i++) for (int i = 0; i < p_info.getColumnCount(); i++)
{ {
@ -4056,19 +4057,8 @@ public abstract class PO
if (p_info.isColumnTranslated(i) if (p_info.isColumnTranslated(i)
&& is_ValueChanged(columnName)) && is_ValueChanged(columnName))
{ {
sqlcols.append(columnName).append("="); sqlcols.append(columnName).append("=?,");
Object value = get_Value(columnName); values.add(get_Value(columnName));
if (value == null)
sqlcols.append("NULL");
else if (value instanceof String)
sqlcols.append(DB.TO_STRING((String)value));
else if (value instanceof Boolean)
sqlcols.append(((Boolean)value).booleanValue() ? "'Y'" : "'N'");
else if (value instanceof Timestamp)
sqlcols.append(DB.TO_DATE((Timestamp)value));
else
sqlcols.append(value.toString());
sqlcols.append(",");
// Reset of related translation cache entries // Reset of related translation cache entries
String[] availableLanguages = Language.getNames(); String[] availableLanguages = Language.getNames();
@ -4088,6 +4078,9 @@ public abstract class PO
int no = -1; int no = -1;
try { try {
Object[] params = new Object[values.size()];
values.toArray(params);
if (client.isMultiLingualDocument()) { if (client.isMultiLingualDocument()) {
if (client.getAD_Language().equals(baselang)) { if (client.getAD_Language().equals(baselang)) {
// tenant language = base language // tenant language = base language
@ -4108,7 +4101,7 @@ public abstract class PO
.append("IsTranslated='Y'") .append("IsTranslated='Y'")
.append(whereid) .append(whereid)
.append(getAD_Client_ID() == 0 ? andBaseLang : andClientLang); .append(getAD_Client_ID() == 0 ? andBaseLang : andClientLang);
no = DB.executeUpdateEx(sqlexec.toString(), m_trxName); no = DB.executeUpdateEx(sqlexec.toString(), params, m_trxName);
if (log.isLoggable(Level.FINE)) log.fine("#" + no); if (log.isLoggable(Level.FINE)) log.fine("#" + no);
if (no >= 0) { if (no >= 0) {
// set other translations as untranslated // set other translations as untranslated
@ -4129,7 +4122,7 @@ public abstract class PO
.append(sqlcols) .append(sqlcols)
.append("IsTranslated='Y'") .append("IsTranslated='Y'")
.append(whereid); .append(whereid);
no = DB.executeUpdateEx(sqlexec.toString(), m_trxName); no = DB.executeUpdateEx(sqlexec.toString(), params, m_trxName);
if (log.isLoggable(Level.FINE)) log.fine("#" + no); if (log.isLoggable(Level.FINE)) log.fine("#" + no);
} }
} catch (DBException e) { } catch (DBException e) {