midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BF [ 1874419 ] JDBC Statement not close in a finally block

This commit is contained in:
teo_sarca 2008-01-29 13:23:43 +00:00
parent cae6ffa8ed
commit 1f5c4d470e
1 changed files with 10 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
client/src/org/compiere/apps/wf/WFActivity.java
View File

@ -287,6 +287,7 @@ public class WFActivity extends CPanel
//+ ") ORDER BY a.Priority DESC, Created"; //+ ") ORDER BY a.Priority DESC, Created";
int AD_User_ID = Env.getAD_User_ID(Env.getCtx()); int AD_User_ID = Env.getAD_User_ID(Env.getCtx());
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
ResultSet rs = null;
try try
{ {
pstmt = DB.prepareStatement (sql, null); pstmt = DB.prepareStatement (sql, null);
@ -294,25 +295,19 @@ public class WFActivity extends CPanel
pstmt.setInt (2, AD_User_ID); pstmt.setInt (2, AD_User_ID);
pstmt.setInt (3, AD_User_ID); pstmt.setInt (3, AD_User_ID);
pstmt.setInt (4, AD_User_ID); pstmt.setInt (4, AD_User_ID);
ResultSet rs = pstmt.executeQuery (); rs = pstmt.executeQuery ();
if (rs.next ()) { if (rs.next ()) {
count = rs.getInt(1); count = rs.getInt(1);
} }
rs.close();
} }
catch (Exception e) catch (Exception e)
{ {
log.log(Level.SEVERE, sql, e); log.log(Level.SEVERE, sql, e);
} }
try finally
{ {
if (pstmt != null) DB.close(rs, pstmt);
pstmt.close (); rs = null; pstmt = null;
pstmt = null;
}
catch (Exception e)
{
pstmt = null;
} }
return count; return count;
@ -344,6 +339,7 @@ public class WFActivity extends CPanel
+ ") ORDER BY a.Priority DESC, Created"; + ") ORDER BY a.Priority DESC, Created";
int AD_User_ID = Env.getAD_User_ID(Env.getCtx()); int AD_User_ID = Env.getAD_User_ID(Env.getCtx());
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
ResultSet rs = null;
try try
{ {
pstmt = DB.prepareStatement (sql, null); pstmt = DB.prepareStatement (sql, null);
@ -351,7 +347,7 @@ public class WFActivity extends CPanel
pstmt.setInt (2, AD_User_ID); pstmt.setInt (2, AD_User_ID);
pstmt.setInt (3, AD_User_ID); pstmt.setInt (3, AD_User_ID);
pstmt.setInt (4, AD_User_ID); pstmt.setInt (4, AD_User_ID);
ResultSet rs = pstmt.executeQuery (); rs = pstmt.executeQuery ();
while (rs.next ()) while (rs.next ())
{ {
list.add (new MWFActivity(Env.getCtx(), rs, null)); list.add (new MWFActivity(Env.getCtx(), rs, null));
@ -361,23 +357,15 @@ public class WFActivity extends CPanel
break; break;
} }
} }
rs.close ();
pstmt.close ();
pstmt = null;
} }
catch (Exception e) catch (Exception e)
{ {
log.log(Level.SEVERE, sql, e); log.log(Level.SEVERE, sql, e);
} }
try finally
{ {
if (pstmt != null) DB.close(rs, pstmt);
pstmt.close (); rs = null; pstmt = null;
pstmt = null;
}
catch (Exception e)
{
pstmt = null;
} }
m_activities = new MWFActivity[list.size ()]; m_activities = new MWFActivity[list.size ()];
list.toArray (m_activities); list.toArray (m_activities);