midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

CRP: prevent infinite loop by introducing MaxIterationsNo variable

This commit is contained in:
teo_sarca 2009-02-02 10:14:44 +00:00
parent f1f759b77e
commit 1e6e8cde09
1 changed files with 27 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
base/src/org/eevolution/process/CRP.java
View File

@ -24,6 +24,7 @@ import java.util.logging.Level;
import org.adempiere.exceptions.AdempiereException; import org.adempiere.exceptions.AdempiereException;
import org.compiere.model.MResource; import org.compiere.model.MResource;
import org.compiere.model.MResourceType; import org.compiere.model.MResourceType;
import org.compiere.model.MSysConfig;
import org.compiere.model.POResultSet; import org.compiere.model.POResultSet;
import org.compiere.process.ProcessInfoParameter; import org.compiere.process.ProcessInfoParameter;
import org.compiere.process.SvrProcess; import org.compiere.process.SvrProcess;
@ -42,43 +43,46 @@ import org.eevolution.model.reasoner.CRPReasoner;
* *
* @author Teo Sarca, www.arhipac.ro * @author Teo Sarca, www.arhipac.ro
*/ */
public class CRP extends SvrProcess { public class CRP extends SvrProcess
{
public static final String FORWARD_SCHEDULING = "F"; public static final String FORWARD_SCHEDULING = "F";
public static final String BACKWARD_SCHEDULING = "B"; public static final String BACKWARD_SCHEDULING = "B";
private int p_S_Resource_ID; private int p_S_Resource_ID;
private String p_ScheduleType; private String p_ScheduleType;
/** SysConfig parameter - maximum number of algorithm iterations */
private int p_MaxIterationsNo = -1;
public static final String SYSCONFIG_MaxIterationsNo = "CRP.MaxIterationsNo";
public static final int DEFAULT_MaxIterationsNo = 1000;
/** CRP Reasoner */
private CRPReasoner reasoner; private CRPReasoner reasoner;
public CRP() {
super();
reasoner = new CRPReasoner();
}
protected void prepare() protected void prepare()
{ {
ProcessInfoParameter[] para = getParameter(); for (ProcessInfoParameter para : getParameter())
for (int i = 0; i < para.length; i++)
{ {
String name = para[i].getParameterName(); String name = para.getParameterName();
if (para[i].getParameter() == null) if (para.getParameter() == null)
; ;
if (name.equals("S_Resource_ID")) { if (name.equals("S_Resource_ID")) {
p_S_Resource_ID = ((BigDecimal)para[i].getParameter()).intValue(); p_S_Resource_ID = para.getParameterAsInt();
} }
else if (name.equals("ScheduleType")) { else if (name.equals("ScheduleType")) {
p_ScheduleType = ((String)para[i].getParameter()); p_ScheduleType = (String)para.getParameter();
} }
else { else {
log.log(Level.SEVERE, "prepare - Unknown Parameter: " + name); log.log(Level.SEVERE, "prepare - Unknown Parameter: " + name);
} }
} }
//
p_MaxIterationsNo = MSysConfig.getIntValue(SYSCONFIG_MaxIterationsNo, DEFAULT_MaxIterationsNo, getAD_Client_ID());
} }
protected String doIt() throws Exception protected String doIt() throws Exception
{ {
reasoner = new CRPReasoner();
return runCRP(); return runCRP();
} }
@ -271,6 +275,10 @@ public class CRP extends SvrProcess {
} }
iteration++; iteration++;
if (iteration > p_MaxIterationsNo)
{
throw new AdempiereException("Maximum number of iterations exceeded ("+p_MaxIterationsNo+")");
}
} while (nodeDurationMillis > 0); } while (nodeDurationMillis > 0);
return end; return end;
@ -334,6 +342,10 @@ public class CRP extends SvrProcess {
} }
// //
iteration++; iteration++;
if (iteration > p_MaxIterationsNo)
{
throw new AdempiereException("Maximum number of iterations exceeded ("+p_MaxIterationsNo+")");
}
} }
while(nodeDurationMillis > 0); while(nodeDurationMillis > 0);