midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

*BF [ 1874419 ] JDBC Statement not close in a finally block 

organize imports
This commit is contained in:
Redhuan D. Oon 2008-02-19 10:44:43 +00:00
parent aa5981ad8f
commit 0be4012cfb
1 changed files with 32 additions and 56 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

82
base/src/org/compiere/model/MLdapProcessor.java
View File

@ -15,10 +15,16 @@
*****************************************************************************/ *****************************************************************************/
package org.compiere.model; package org.compiere.model;
import java.sql.*; import java.sql.PreparedStatement;
import java.util.*; import java.sql.ResultSet;
import java.util.logging.*; import java.sql.Timestamp;
import org.compiere.util.*; import java.util.ArrayList;
import java.util.Properties;
import java.util.logging.Level;
import org.compiere.util.CLogger;
import org.compiere.util.DB;
import org.compiere.util.Msg;
/** /**
@ -38,31 +44,23 @@ public class MLdapProcessor extends X_AD_LdapProcessor implements AdempiereProce
ArrayList<MLdapProcessor> list = new ArrayList<MLdapProcessor>(); ArrayList<MLdapProcessor> list = new ArrayList<MLdapProcessor>();
String sql = "SELECT * FROM AD_LdapProcessor WHERE IsActive='Y'"; String sql = "SELECT * FROM AD_LdapProcessor WHERE IsActive='Y'";
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
ResultSet rs = null;
try try
{ {
pstmt = DB.prepareStatement (sql, null); pstmt = DB.prepareStatement (sql, null);
ResultSet rs = pstmt.executeQuery (); rs = pstmt.executeQuery ();
while (rs.next ()) while (rs.next ())
list.add (new MLdapProcessor (ctx, rs, null)); list.add (new MLdapProcessor (ctx, rs, null));
rs.close ();
pstmt.close ();
pstmt = null;
} }
catch (Exception e) catch (Exception e)
{ {
log.log (Level.SEVERE, sql, e); log.log (Level.SEVERE, sql, e);
} }
try finally
{ {
if (pstmt != null) DB.close(rs, pstmt);
pstmt.close (); rs = null; pstmt = null;
pstmt = null;
} }
catch (Exception e)
{
pstmt = null;
}
MLdapProcessor[] retValue = new MLdapProcessor[list.size()]; MLdapProcessor[] retValue = new MLdapProcessor[list.size()];
list.toArray(retValue); list.toArray(retValue);
return retValue; return retValue;
@ -145,30 +143,23 @@ public class MLdapProcessor extends X_AD_LdapProcessor implements AdempiereProce
+ "WHERE AD_LdapProcessor_ID=? " + "WHERE AD_LdapProcessor_ID=? "
+ "ORDER BY Created DESC"; + "ORDER BY Created DESC";
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
ResultSet rs = null;
try try
{ {
pstmt = DB.prepareStatement (sql, get_TrxName()); pstmt = DB.prepareStatement (sql, get_TrxName());
pstmt.setInt (1, getAD_LdapProcessor_ID()); pstmt.setInt (1, getAD_LdapProcessor_ID());
ResultSet rs = pstmt.executeQuery (); rs = pstmt.executeQuery ();
while (rs.next ()) while (rs.next ())
list.add (new MLdapProcessorLog (getCtx(), rs, get_TrxName())); list.add (new MLdapProcessorLog (getCtx(), rs, get_TrxName()));
rs.close ();
pstmt.close ();
pstmt = null;
} }
catch (Exception e) catch (Exception e)
{ {
log.log(Level.SEVERE, sql, e); log.log(Level.SEVERE, sql, e);
} }
try finally
{ {
if (pstmt != null) DB.close(rs, pstmt);
pstmt.close (); rs = null; pstmt = null;
pstmt = null;
}
catch (Exception e)
{
pstmt = null;
} }
MLdapProcessorLog[] retValue = new MLdapProcessorLog[list.size ()]; MLdapProcessorLog[] retValue = new MLdapProcessorLog[list.size ()];
list.toArray (retValue); list.toArray (retValue);
@ -299,6 +290,7 @@ public class MLdapProcessor extends X_AD_LdapProcessor implements AdempiereProce
+ "FROM AD_User " + "FROM AD_User "
+ "WHERE AD_Client_ID=? AND (EMail=? OR Value=? OR LdapUser=?)"; + "WHERE AD_Client_ID=? AND (EMail=? OR Value=? OR LdapUser=?)";
PreparedStatement pstmt = null; PreparedStatement pstmt = null;
ResultSet rs = null;
try try
{ {
pstmt = DB.prepareStatement (sql, null); pstmt = DB.prepareStatement (sql, null);
@ -306,7 +298,7 @@ public class MLdapProcessor extends X_AD_LdapProcessor implements AdempiereProce
pstmt.setString (2, usr); pstmt.setString (2, usr);
pstmt.setString (3, usr); pstmt.setString (3, usr);
pstmt.setString (4, usr); pstmt.setString (4, usr);
ResultSet rs = pstmt.executeQuery (); rs = pstmt.executeQuery ();
if (rs.next()) if (rs.next())
{ {
AD_User_ID = rs.getInt (1); AD_User_ID = rs.getInt (1);
@ -320,24 +312,16 @@ public class MLdapProcessor extends X_AD_LdapProcessor implements AdempiereProce
EMailVerify = rs.getString (8); EMailVerify = rs.getString (8);
isUnique = rs.next(); isUnique = rs.next();
} }
rs.close ();
pstmt.close ();
pstmt = null;
} }
catch (Exception e) catch (Exception e)
{ {
log.log (Level.SEVERE, sql, e); log.log (Level.SEVERE, sql, e);
error = "System Error"; error = "System Error";
} }
try finally
{ {
if (pstmt != null) DB.close(rs, pstmt);
pstmt.close (); rs = null; pstmt = null;
pstmt = null;
}
catch (Exception e)
{
pstmt = null;
} }
if (error != null) if (error != null)
{ {
@ -405,7 +389,7 @@ public class MLdapProcessor extends X_AD_LdapProcessor implements AdempiereProce
pstmt = DB.prepareStatement (sql, null); pstmt = DB.prepareStatement (sql, null);
pstmt.setInt (1, R_InterestArea_ID); pstmt.setInt (1, R_InterestArea_ID);
pstmt.setInt (2, AD_User_ID); pstmt.setInt (2, AD_User_ID);
ResultSet rs = pstmt.executeQuery (); rs = pstmt.executeQuery ();
if (rs.next()) if (rs.next())
{ {
found = true; found = true;
@ -413,24 +397,16 @@ public class MLdapProcessor extends X_AD_LdapProcessor implements AdempiereProce
OptOutDate = rs.getString (2); OptOutDate = rs.getString (2);
isUnique = rs.next(); isUnique = rs.next();
} }
rs.close ();
pstmt.close ();
pstmt = null;
} }
catch (Exception e) catch (Exception e)
{ {
log.log (Level.SEVERE, sql, e); log.log (Level.SEVERE, sql, e);
error = "System Error (2)"; error = "System Error (2)";
} }
try finally
{ {
if (pstmt != null) DB.close(rs, pstmt);
pstmt.close (); rs = null; pstmt = null;
pstmt = null;
}
catch (Exception e)
{
pstmt = null;
} }
// System Error // System Error
if (error != null) if (error != null)