midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[ 1746266 ] Convert fails for type only ALTER...MODIFY statement

This commit is contained in:
Heng Sin Low 2007-07-02 04:57:13 +00:00
parent 9a929f1dc6
commit 09de60d04c
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
base/src/org/compiere/dbPort/Convert_PostgreSQL.java
View File

@ -1000,8 +1000,8 @@ public class Convert_PostgreSQL extends Convert_SQL92 {
else else
{ {
int typeEnd = rest.indexOf(' '); int typeEnd = rest.indexOf(' ');
type = rest.substring(0, typeEnd).trim(); type = typeEnd > 0 ? rest.substring(0, typeEnd).trim() : rest;
rest = rest.substring(typeEnd); rest = typeEnd > 0 ? rest.substring(typeEnd) : "";
} }
if (rest.toUpperCase().indexOf(" DEFAULT ") != -1) { if (rest.toUpperCase().indexOf(" DEFAULT ") != -1) {

6
base/src/org/compiere/dbPort/Convert_PostgreSQLTest.java
View File

@ -78,6 +78,12 @@ public final class Convert_PostgreSQLTest extends TestCase{
sqe = "ALTER TABLE XX ADD COLUMN A VARCHAR(10) DEFAULT '--'"; sqe = "ALTER TABLE XX ADD COLUMN A VARCHAR(10) DEFAULT '--'";
r = convert.convert(sql); r = convert.convert(sql);
assertEquals(sqe, r[0].trim()); assertEquals(sqe, r[0].trim());
//[ adempiere-Bugs-1746266 ]
sql = "ALTER TABLE someTableName MODIFY someColumnName NVARCHAR2(64)";
sqe = "insert into t_alter_column values('sometablename','someColumnName','VARCHAR(64)',null,null)";
r = convert.convert(sql);
assertEquals(sqe, r[0].trim());
} }
// Convert.recoverQuotedStrings() error on strings with "<-->" - teo_sarca [ 1705768 ] // Convert.recoverQuotedStrings() error on strings with "<-->" - teo_sarca [ 1705768 ]