midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IDEMPIERE-455 Discover and fix FindBugs problems / Pattern LSYC_LOCAL_SYNCHRONIZED

This commit is contained in:
Richard Morales 2012-12-13 18:11:40 -05:00
parent dc07ce8e37
commit 024c8d35c9
6 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
org.adempiere.base.process/src/org/adempiere/process/PrepareMigrationScripts.java
View File

@ -34,9 +34,9 @@ import java.io.FilenameFilter;
import java.sql.PreparedStatement; import java.sql.PreparedStatement;
import java.sql.ResultSet; import java.sql.ResultSet;
import java.sql.Timestamp; import java.sql.Timestamp;
import java.util.ArrayList;
import java.util.Calendar; import java.util.Calendar;
import java.util.Scanner; import java.util.Scanner;
import java.util.Vector;
import java.util.logging.Level; import java.util.logging.Level;
import org.compiere.Adempiere; import org.compiere.Adempiere;
@ -63,7 +63,7 @@ public class PrepareMigrationScripts extends SvrProcess {
// The list of files can also be retrieved as File objects // The list of files can also be retrieved as File objects
File[] dirList = dir.listFiles(); File[] dirList = dir.listFiles();
Vector<String> fileName = new Vector<String>(); ArrayList<String> fileName = new ArrayList<String>();
FilenameFilter filter = new FilenameFilter() { FilenameFilter filter = new FilenameFilter() {
public boolean accept(File dir, String name) { public boolean accept(File dir, String name) {

5
org.adempiere.base/src/org/compiere/model/MRole.java
View File

@ -33,7 +33,6 @@ import java.util.List;
import java.util.Map.Entry; import java.util.Map.Entry;
import java.util.Properties; import java.util.Properties;
import java.util.Set; import java.util.Set;
import java.util.Vector;
import java.util.logging.Level; import java.util.logging.Level;
import org.adempiere.exceptions.AdempiereException; import org.adempiere.exceptions.AdempiereException;
@ -2494,7 +2493,7 @@ public final class MRole extends X_AD_Role
if (maxIndex <= 0) if (maxIndex <= 0)
return maxIndex; return maxIndex;
// //
final Vector<String> validOptions = new Vector<String>(); final ArrayList<String> validOptions = new ArrayList<String>();
final List<Object> params = new ArrayList<Object>(); final List<Object> params = new ArrayList<Object>();
params.add(clientId); params.add(clientId);
params.add(docTypeId); params.add(docTypeId);
@ -2519,7 +2518,7 @@ public final class MRole extends X_AD_Role
if (roles.size() > 0) { if (roles.size() > 0) {
MDocType doc = new MDocType(getCtx(), docTypeId, get_TrxName()); MDocType doc = new MDocType(getCtx(), docTypeId, get_TrxName());
Vector<String> option = new Vector<String>(); ArrayList<String> option = new ArrayList<String>();
for (int j = 0; j < options.length; j++) { for (int j = 0; j < options.length; j++) {
if (options[j] != null) if (options[j] != null)
option.add(options[j]); option.add(options[j]);

4
org.adempiere.base/src/org/compiere/print/ServerReportCtl.java
View File

@ -1,7 +1,7 @@
package org.compiere.print; package org.compiere.print;
import java.util.ArrayList;
import java.util.Properties; import java.util.Properties;
import java.util.Vector;
import java.util.logging.Level; import java.util.logging.Level;
import org.compiere.model.MProcess; import org.compiere.model.MProcess;
@ -90,7 +90,7 @@ public class ServerReportCtl {
ProcessInfo pi = new ProcessInfo ("", format.getJasperProcess_ID()); ProcessInfo pi = new ProcessInfo ("", format.getJasperProcess_ID());
pi.setPrintPreview( !IsDirectPrint ); pi.setPrintPreview( !IsDirectPrint );
pi.setRecord_ID ( Record_ID ); pi.setRecord_ID ( Record_ID );
Vector<ProcessInfoParameter> jasperPrintParams = new Vector<ProcessInfoParameter>(); ArrayList<ProcessInfoParameter> jasperPrintParams = new ArrayList<ProcessInfoParameter>();
ProcessInfoParameter pip; ProcessInfoParameter pip;
if (printerName!=null && printerName.trim().length()>0) { if (printerName!=null && printerName.trim().length()>0) {
// Override printer name // Override printer name

5
org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/adwindow/AbstractADWindowContent.java
View File

@ -30,7 +30,6 @@ import java.util.Map;
import java.util.Properties; import java.util.Properties;
import java.util.Set; import java.util.Set;
import java.util.TreeMap; import java.util.TreeMap;
import java.util.Vector;
import java.util.logging.Level; import java.util.logging.Level;
import org.adempiere.util.Callback; import org.adempiere.util.Callback;
@ -1872,7 +1871,7 @@ public abstract class AbstractADWindowContent extends AbstractUIPart implements
listbox.setHeight("400px"); listbox.setHeight("400px");
// Display the first 5 fields data exclude Organization, Client and YesNo field data // Display the first 5 fields data exclude Organization, Client and YesNo field data
Vector<String> columnNames = new Vector<String>(); ArrayList<String> columnNames = new ArrayList<String>();
GridField[] fields = adTabbox.getSelectedGridTab().getFields(); GridField[] fields = adTabbox.getSelectedGridTab().getFields();
if(adTabbox.getSelectedGridTab().getField("DocumentNo")!=null){ if(adTabbox.getSelectedGridTab().getField("DocumentNo")!=null){
columnNames.add(adTabbox.getSelectedGridTab().getField("DocumentNo").getColumnName()); columnNames.add(adTabbox.getSelectedGridTab().getField("DocumentNo").getColumnName());
@ -1899,7 +1898,7 @@ public abstract class AbstractADWindowContent extends AbstractUIPart implements
} }
} }
Vector<String> data = new Vector<String>(); ArrayList<String> data = new ArrayList<String>();
int noOfRows = adTabbox.getSelectedGridTab().getRowCount(); int noOfRows = adTabbox.getSelectedGridTab().getRowCount();
for(int i=0; i<noOfRows; i++) for(int i=0; i<noOfRows; i++)
{ {

5
org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/window/WFieldRecordInfo.java
View File

@ -20,6 +20,7 @@ import java.sql.ResultSet;
import java.sql.Timestamp; import java.sql.Timestamp;
import java.text.DecimalFormat; import java.text.DecimalFormat;
import java.text.SimpleDateFormat; import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.Vector; import java.util.Vector;
import java.util.logging.Level; import java.util.logging.Level;
@ -48,10 +49,10 @@ import org.zkoss.zk.ui.event.EventListener;
import org.zkoss.zk.ui.event.Events; import org.zkoss.zk.ui.event.Events;
import org.zkoss.zul.Borderlayout; import org.zkoss.zul.Borderlayout;
import org.zkoss.zul.Center; import org.zkoss.zul.Center;
import org.zkoss.zul.South;
import org.zkoss.zul.Listhead; import org.zkoss.zul.Listhead;
import org.zkoss.zul.Listheader; import org.zkoss.zul.Listheader;
import org.zkoss.zul.Menuitem; import org.zkoss.zul.Menuitem;
import org.zkoss.zul.South;
/** /**
* Change History for field * Change History for field
@ -204,7 +205,7 @@ public class WFieldRecordInfo extends Window implements EventListener<Event>
} }
// //
Vector<String> columnNames = new Vector<String>(); ArrayList<String> columnNames = new ArrayList<String>();
columnNames.add(Msg.translate(Env.getCtx(), "NewValue")); columnNames.add(Msg.translate(Env.getCtx(), "NewValue"));
columnNames.add(Msg.translate(Env.getCtx(), "OldValue")); columnNames.add(Msg.translate(Env.getCtx(), "OldValue"));
columnNames.add(Msg.translate(Env.getCtx(), "UpdatedBy")); columnNames.add(Msg.translate(Env.getCtx(), "UpdatedBy"));

7
org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/window/WRecordInfo.java
View File

@ -22,6 +22,7 @@ import java.sql.ResultSet;
import java.sql.Timestamp; import java.sql.Timestamp;
import java.text.DecimalFormat; import java.text.DecimalFormat;
import java.text.SimpleDateFormat; import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.Vector; import java.util.Vector;
import java.util.logging.Level; import java.util.logging.Level;
@ -51,11 +52,11 @@ import org.zkoss.zk.ui.event.EventListener;
import org.zkoss.zk.ui.event.Events; import org.zkoss.zk.ui.event.Events;
import org.zkoss.zul.Borderlayout; import org.zkoss.zul.Borderlayout;
import org.zkoss.zul.Center; import org.zkoss.zul.Center;
import org.zkoss.zul.North;
import org.zkoss.zul.South;
import org.zkoss.zul.Div; import org.zkoss.zul.Div;
import org.zkoss.zul.Listhead; import org.zkoss.zul.Listhead;
import org.zkoss.zul.Listheader; import org.zkoss.zul.Listheader;
import org.zkoss.zul.North;
import org.zkoss.zul.South;
/** /**
* Record Info (Who) With Change History * Record Info (Who) With Change History
@ -263,7 +264,7 @@ public class WRecordInfo extends Window implements EventListener<Event>
} }
// //
Vector<String> columnNames = new Vector<String>(); ArrayList<String> columnNames = new ArrayList<String>();
columnNames.add(Msg.translate(Env.getCtx(), "Name")); columnNames.add(Msg.translate(Env.getCtx(), "Name"));
columnNames.add(Msg.translate(Env.getCtx(), "NewValue")); columnNames.add(Msg.translate(Env.getCtx(), "NewValue"));
columnNames.add(Msg.translate(Env.getCtx(), "OldValue")); columnNames.add(Msg.translate(Env.getCtx(), "OldValue"));